Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search words option does not work #2698

Closed
medienbaecker opened this issue Jul 9, 2020 · 2 comments · Fixed by #2699
Closed

Search words option does not work #2698

medienbaecker opened this issue Jul 9, 2020 · 2 comments · Fixed by #2699
Assignees
@afbora
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone
3.4.1

Comments

@medienbaecker
Copy link
Contributor

medienbaecker commented Jul 9, 2020 •
edited

Describe the bug
The words option does not have any effect on search results: https://forum.getkirby.com/t/words-true-not-affecting-search-results/18620

To Reproduce
Compare

$pages->search('special', ['words' => false]);

with

$pages->search('special', ['words' => true]);

Expected behavior
The second example should not return search results with the word especially. The first one should. Both do.

Kirby Version
Happens with every Kirby version I tested.
@medienbaecker medienbaecker changed the title words => true does not work Search words option does not work Jul 9, 2020
@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Jul 9, 2020
@afbora
Copy link
Member

afbora commented Jul 9, 2020

Related lines about the issue:

https://github.com/getkirby/kirby/blob/3.4.0/config/components.php#L222-L226

afbora added a commit that referenced this issue Jul 9, 2020
@afbora
Fix search words option #2698
1793466
@afbora afbora self-assigned this Jul 9, 2020
@afbora afbora mentioned this issue Jul 9, 2020
Merged
4 tasks
@bastianallgeier
Copy link
Member

✅

@afbora afbora added this to the 3.4.1 milestone Jul 10, 2020
@afbora afbora linked a pull request Jul 10, 2020 that will close this issue
Fix search words option #2699
Merged
4 tasks
bastianallgeier pushed a commit that referenced this issue Aug 4, 2020
@afbora @bastianallgeier
Fix search words option #2698
8124514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
3.4.1
Development

Successfully merging a pull request may close this issue.

Fix search words option getkirby/kirby
3 participants
@bastianallgeier @afbora @medienbaecker