Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileCache: Clean up empty directories on remove() #3162

Closed
lukasbestle opened this issue Feb 19, 2021 · 1 comment · Fixed by #3199
Closed

FileCache: Clean up empty directories on remove() #3162

lukasbestle opened this issue Feb 19, 2021 · 1 comment · Fixed by #3199
Assignees
@afbora
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone
3.5.5

Comments

@lukasbestle
Copy link
Member

When a cache item is removed, it may leave behind an empty directory.

The FileCache::remove() method should check if the directory the item was in is now empty. If it is, it should delete the empty directory. Then it should check the same for the next level up until the root is reached (which should not be deleted).
@lukasbestle lukasbestle added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Feb 19, 2021
@lukasbestle lukasbestle added this to the 3.5.x milestone Feb 19, 2021
afbora added a commit that referenced this issue Mar 10, 2021
@afbora
FileCache: Clean up empty directories on remove() #3162
83c3e79
@afbora afbora mentioned this issue Mar 10, 2021
Merged
4 tasks
afbora added a commit that referenced this issue Mar 10, 2021
@afbora
FileCache: Clean up empty directories on remove() #3162
6640fa4
@afbora afbora self-assigned this Mar 10, 2021
@afbora afbora linked a pull request Mar 10, 2021 that will close this issue
FileCache: Clean up empty directories on remove() #3162 #3199
Merged
4 tasks
@afbora afbora modified the milestones: 3.5.x, 3.5.4 Mar 12, 2021
afbora added a commit that referenced this issue Mar 13, 2021
@afbora
Use iterative approach on removing empty directories #3162
f03f75a 
Since there may be a performance problem, an iterative solution that suggested by @lukasbestle  has been applied instead of recursive.
afbora added a commit that referenced this issue Mar 13, 2021
@afbora
Add "not empty dirs" unit test for FileCache::removeEmptyDirectories #…
34b3eab 
…3162
afbora added a commit that referenced this issue Mar 14, 2021
@afbora
Add missing FileCache::removeEmptyDirectories() description in doc bl…
991b0be 
…ock #3162
bastianallgeier added a commit that referenced this issue Mar 17, 2021
@bastianallgeier
Merge pull request #3199 from getkirby/fix/3162-filecache-clean-up-em…
cadb6e5 
…pty-directories

FileCache: Clean up empty directories on remove() #3162
@bastianallgeier
Copy link
Member

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
3.5.5
Development

Successfully merging a pull request may close this issue.

FileCache: Clean up empty directories on remove() #3162 getkirby/kirby
3 participants
@bastianallgeier @lukasbestle @afbora