Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks field inconsistent max items behaviour #3179

Closed
bvdputte opened this issue Feb 24, 2021 · 1 comment · Fixed by #3181
Closed

Blocks field inconsistent max items behaviour #3179

bvdputte opened this issue Feb 24, 2021 · 1 comment · Fixed by #3181
Assignees
@afbora
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone
3.5.5

Comments

@bvdputte
Copy link

bvdputte commented Feb 24, 2021 •
edited

Describe the bug
Is it expected for a blocks field that has a max specified I can still "add" an item via the UI top right? I can't save it (I get an error then), but it seems inconsistent with other max-ui that hides the "add" functionality when the threshold is reached

To Reproduce

  1. Add a blocks field with e.g. max: 3
  2. Login to the panel and try to add 4 items
  3. No notification when trying to add 4th item

Expected behavior
After the 3rd block is added I'ld expect the "add" Ui to be hidden.

Kirby Version
3.5.3

Desktop:

  • OS: macOS
  • Browser: Firefox 85.0.2
@afbora afbora added type: enhancement ✨ Suggests an enhancement; improves Kirby difficulty: easy 🤩 labels Feb 25, 2021
@afbora afbora added this to the 3.5.4 milestone Feb 25, 2021
@afbora afbora self-assigned this Feb 25, 2021
afbora added a commit that referenced this issue Feb 25, 2021
@afbora
Disable add menu items when blocks field max #3179
2d74d11
@afbora afbora mentioned this issue Feb 25, 2021
Merged
4 tasks
@afbora afbora linked a pull request Feb 25, 2021 that will close this issue
Disable add menu items when blocks field max #3179 #3181
Merged
4 tasks
bastianallgeier added a commit that referenced this issue Feb 26, 2021
@bastianallgeier
Merge pull request #3181 from getkirby/fix/3179-disabled-menu-items-w…
4bbc96c 
…hen-max

Disable `add` menu items when blocks field max #3179
@bastianallgeier
Copy link
Member

✅

@afbora afbora mentioned this issue Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
3.5.5
Development

Successfully merging a pull request may close this issue.

Disable add menu items when blocks field max #3179 getkirby/kirby
3 participants
@bastianallgeier @bvdputte @afbora