Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks field: delete button inside the drawer #3180

Closed
bvdputte opened this issue Feb 24, 2021 · 3 comments · Fixed by #3272
Closed

Blocks field: delete button inside the drawer #3180

bvdputte opened this issue Feb 24, 2021 · 3 comments · Fixed by #3272
Assignees
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone

Comments

@bvdputte
Copy link

Describe the bug
How do I "cancel" the addition of a block to the blocks field?

To Reproduce
When I click "add", the drawer opens but I cannot cancel it? When I click away from the drawer; the drawer is closed; but an empty block is added.

Expected behavior
Add an obvious "cancel" link, (maybe als add a listener to the "ESC" key) which closes the drawer without adding an empty block.

Kirby Version
3.5.3

Desktop:

  • OS: macOS
  • Browser: Firefox 85.0.2
@afbora
Copy link
Member

afbora commented Feb 25, 2021

The drawer will already close when you press the escape key while the drawer is open. But when the escape key is pressed, IMO we cannot know if this is to close or cancel. Maybe a delete button can be added on the drawer 🤔

@bastianallgeier
Copy link
Member

In the blocks field, a new block is already fully created once you click on the selected type. I like @afbora to still offer a good way to directly delete the block inside the drawer instead of "cancelling" the new block.

@afbora afbora added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Feb 26, 2021
@afbora afbora self-assigned this Mar 10, 2021
@afbora afbora added this to the 3.5.x milestone Mar 10, 2021
@afbora afbora changed the title Blocks field: cancel behaviour Blocks field: delete button inside the drawer Apr 27, 2021
@afbora afbora modified the milestones: 3.5.x, 3.5.5 Apr 27, 2021
@afbora afbora linked a pull request Apr 27, 2021 that will close this issue
4 tasks
@bastianallgeier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants