Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message on empty URL appendix #3205

Closed
salimromadhon opened this issue Mar 12, 2021 · 8 comments · Fixed by #3212
Closed

Wrong error message on empty URL appendix #3205

salimromadhon opened this issue Mar 12, 2021 · 8 comments · Fixed by #3212
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@salimromadhon
Copy link

I'm on Firefox and get this error when the URL appendix is empty:

image

I also get the same result when trying on trykirby.com. Yeah it's very minor but has to be fixed. :)

@lukasbestle
Copy link
Member

@salimromadhon What would be the expected behavior for you?

@lukasbestle lukasbestle added the needs: information ❓ Requires more information to proceed label Mar 12, 2021
@texnixe
Copy link
Member

texnixe commented Mar 12, 2021

Maybe a misunderstanding, because it's rather unclear what a URL appendix is supposed to be? And the field is called URL appendix whereas the error messages says prefix. I think the field should really be called slug, or even folder name, then it's also clearer why it must be required?

@lukasbestle
Copy link
Member

@texnixe Yes, both points make a lot of sense!

@bastianallgeier
Copy link
Member

The only reason why I went for URL appendix was the weirdness of the term slug. I also have zero idea how to translate that to German for example. Folder name is also kind of weird when editors often don't have any knowledge about the underlying file system and that Kirby is just renaming folders.

@lukasbestle
Copy link
Member

Slug has pretty much become an established term, even in German. If we do decide to stay with "URL appendix" (which would be fine for me as well), we just need to fix the error message to be consistent. I think that's what @salimromadhon meant.

@texnixe
Copy link
Member

texnixe commented Mar 12, 2021

I think we really need to unify our wording more:

  • changeUrl
  • changeSlug()
  • URL appendix
  • $page->slug()
  • URL prefix

@salimromadhon
Copy link
Author

And the field is called URL appendix whereas the error messages says prefix.

Yep that's what I mean. The error message should says URL appendix as well.

Yeah translating technical things sometimes goes tricky as not every term has its "as is" corresponding meaning. I'm OK with "slug" or "URL appendix". Both of them can't be directly translated into Indonesia, even strictly translating it can lead to confusing rather than leaving it untranslated.

For this case I prefer "URL appendix" where can be more meaningfully translated into Indonesia as "Akhiran URL". It's mixed language Indonesia-English. But I think it's OK as Google does the same way in translating their products, especially for Indonesia.

@lukasbestle lukasbestle added difficulty: easy 🤩 type: bug 🐛 Is a bug; fixes a bug and removed needs: information ❓ Requires more information to proceed labels Mar 16, 2021
@lukasbestle lukasbestle added this to the 3.5.4 milestone Mar 16, 2021
@afbora afbora linked a pull request Mar 16, 2021 that will close this issue
2 tasks
bastianallgeier added a commit that referenced this issue Mar 17, 2021
Fix error.page.slug.invalid translation #3205
@afbora
Copy link
Member

afbora commented Mar 17, 2021

@afbora afbora closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants