Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when clicking non-translatable files field in 2. language #3220

Closed
moritzebeling opened this issue Mar 22, 2021 · 3 comments · Fixed by #3221
Closed

Error when clicking non-translatable files field in 2. language #3220

moritzebeling opened this issue Mar 22, 2021 · 3 comments · Fixed by #3221
Assignees
@afbora
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone
3.5.5

Comments

@moritzebeling
Copy link

Describe the bug
Non-translatable files field throws an error when clicking it in the secondary language.

To Reproduce

  1. Have a multilang Kirby setup
  2. Create an image field, that is non-translatable
coverImage:
  type: files
  multiple: false
  translate: false
  1. Upload an image to the Kirby panel
  2. Switch to the default language and try to select an image. It works, great! Clear the field again.
  3. Switch to the secondary language. The "Select"-button is now hidden
  4. Klick on the field anyways. The following error-message appears:
undefined is not an object (evaluating 'this.$refs.picker.toggle')

Screenshots
Bildschirmfoto 2021-03-22 um 23 56 27
Bildschirmfoto 2021-03-22 um 23 56 31

Kirby Version
3.5.3.1

Machine:
Safari on Mac
@afbora afbora self-assigned this Mar 23, 2021
@afbora afbora added this to the 3.5.4 milestone Mar 23, 2021
afbora added a commit that referenced this issue Mar 23, 2021
@afbora
Checks whether the field disabled on prompt() method in files field #…
f7ab8bb 
…3220
@afbora afbora mentioned this issue Mar 23, 2021
Merged
4 tasks
@afbora afbora linked a pull request Mar 23, 2021 that will close this issue
Checks whether the field disabled on prompt() method in files field #3221
Merged
4 tasks
@bastianallgeier
Copy link
Member

✅

@AnnikaVennemann-JUNO
Copy link

Using the same file settings as above, the picker-toggle triggers a similar error message for my non-translatable fields (Kirby version 3.5.4).

kirby-image-bug

@afbora
Copy link
Member

afbora commented Apr 29, 2021

@AnnikaVennemann-JUNO This issue fixed on 3.5.5 and 3.5.5 RC will be released on May 4th.
I've tested again on develop branch to sure and works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
3.5.5
Development

Successfully merging a pull request may close this issue.

Checks whether the field disabled on prompt() method in files field getkirby/kirby
4 participants
@bastianallgeier @afbora @moritzebeling @AnnikaVennemann-JUNO