Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video block does not save caption writer fields formats #3264

Closed
Lieblingstyp opened this issue Apr 23, 2021 · 4 comments · Fixed by #3265
Closed

Video block does not save caption writer fields formats #3264

Lieblingstyp opened this issue Apr 23, 2021 · 4 comments · Fixed by #3265
Assignees
@afbora
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone
3.5.5

Comments

@Lieblingstyp
Copy link

As said in the title: The video blocks does not save the marks inside the caption field and you're unable to style the caption outside the drawer.
@afbora
Copy link
Member

afbora commented Apr 23, 2021

I know this is about missing :caption-marks prop.
@bastianallgeier Image block have this prop but Video block not.
Is this intended or missing?

https://github.com/getkirby/kirby/blob/3.5.3.1/panel/src/components/Blocks/Types/Image.vue#L4

@bastianallgeier
Copy link
Member

It's not intended

@afbora afbora self-assigned this Apr 23, 2021
@afbora afbora added this to the 3.5.5 milestone Apr 23, 2021
afbora added a commit that referenced this issue Apr 23, 2021
@afbora
Fixes video block caption marks #3264
c4ff1ff
@afbora afbora mentioned this issue Apr 23, 2021
Merged
4 tasks
@afbora afbora linked a pull request Apr 23, 2021 that will close this issue
Fixes video block caption marks #3264 #3265
Merged
4 tasks
bastianallgeier added a commit that referenced this issue Apr 23, 2021
@bastianallgeier
Merge pull request #3265 from getkirby/fix/3264-video-block-caption-m…
5b3c62c 
…arks

Fixes video block caption marks #3264
@afbora
Copy link
Member

afbora commented Apr 23, 2021

✅

@afbora afbora closed this as completed Apr 23, 2021
@Lieblingstyp
Copy link
Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
3.5.5
Development

Successfully merging a pull request may close this issue.

Fixes video block caption marks #3264 getkirby/kirby
3 participants
@bastianallgeier @Lieblingstyp @afbora