Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel: pages field with „link: true“ clickable only after reload #3983

Closed
hannesherold opened this issue Dec 2, 2021 · 3 comments
Closed
Assignees
Labels
type: regression 🚨 Is a regression between versions
Milestone

Comments

@hannesherold
Copy link

Describe the bug
If the option link: true is set for a Pages Field in the blueprint, the referenced page is only clickable after reloading the page in the panel. Immediately after setting the reference or saving the page, the field behaves like link: false.

To Reproduce
Steps to reproduce the behavior:

  1. Install current plainkit and panel
  2. Create pages field with link: true in blueprint
  3. In the panel, add a page to the pages field and save
  4. Try to klick the referenced page in the pages field

Expected behavior
The referenced page should be clickable right after it has been selected.

Screenshot-Video
https://user-images.githubusercontent.com/46819942/144401413-f7cec2fd-fcc4-4eaa-8d4a-09a9a6439b18.mov

Kirby Version
3.6

Console output
No console messages.

Desktop (please complete the following information):

  • OS: macOS 12.0.1
  • Browser: Opera, Firefox, Safari
@afbora afbora added the type: regression 🚨 Is a regression between versions label Dec 2, 2021
@afbora
Copy link
Member

afbora commented Dec 2, 2021

@distantnative Also doesn't work for link: false. I think this prop got corrupted when moving to items/item component.

@distantnative
Copy link
Member

distantnative commented Dec 19, 2021

Are we sure this is a regression. At first look, I don't think it's related to items/item refactoring, but rather that the picker does not pass the link data for freshly selected pages to the field itself. I would assume that bug existed before too.

UPDATE: Ok I checked, it is a regression - not present in 3.5.8.

@bastianallgeier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression 🚨 Is a regression between versions
Projects
None yet
Development

No branches or pull requests

4 participants