pattern property not working with url fields

[silllli]

Description

The pattern property to validate input doesn’t work with url fields.

Expected behavior

Setting a regex pattern that validates user input in the panel should prevent saving differing values.

To reproduce

1. Create a blueprint featuring a url field
2. Set this pattern to match Vimeo links pattern: '^(http\:\/\/|https\:\/\/)?(www\.)?(vimeo\.com\/)([0-9]+)$‘
3. Enter anything but a Vimeo url, e. g. https://getkirby.com
4. Save the value despite not matching the pattern

someUrl:
  type: url
  pattern: '^(http\:\/\/|https\:\/\/)?(www\.)?(vimeo\.com\/)([0-9]+)$'

Your setup

Kirby Version

Your system (please complete the following information)

• Device: MacBook Pro
• OS: macOS 12.5.1
• Browser: Safari
• Version: 15.6.1

Additional context

Changing the field type to text makes the pattern validation work.

[texnixe]

This is because the url field uses the minlength, maxlength and url validators, whereas the text field uses minlength, maxlength and pattern. So pattern is not supported for the url field.

[afbora]

@texnixe pattern prop listing for the url field. That's confusing.
https://getkirby.com/docs/reference/panel/fields/url#field-properties

[silllli]

@texnixe pattern prop listing for the url field. That's confusing.
https://getkirby.com/docs/reference/panel/fields/url#field-properties

That’s how I got the idea 🙂 I think it’s no problem if you have a special pattern like mine (and can use a text field instead), the docs just needed to be updated.

[afbora]

I think we should add the pattern prop to Unset inherited props and remove it from the documentation. What do you think?

kirby/config/fields/url.php

Lines 8 to 13 in cfac315

	/**
	* Unset inherited props
	*/
	'converter' => null,
	'counter' => null,
	'spellcheck' => null,

[lukasbestle]

Funny how we both looked at this issue at the same time and came to the same conclusion :D

[afbora]

To be honest, I was also surprised when you were able to PR so fast😄

[lukasbestle]

✅