Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing image dimensions / orientation of avif files #6141

Closed
crisgraphics opened this issue Jan 13, 2024 · 3 comments · Fixed by #6143
Closed

Missing image dimensions / orientation of avif files #6141

crisgraphics opened this issue Jan 13, 2024 · 3 comments · Fixed by #6143
Assignees
@distantnative
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Milestone
4.0.4

Comments

@crisgraphics
Copy link

Hello,
when I upload avif files in the panel, the resulting uploads don't have any infos about dimension or orientation.
Is it possible to add that, so that I can use file methods like width(), height() and orientation() etc...?

(Ps: sorry if in advance, if this has been brought up before - couldn't find any related issue.)

Screenshots
avif-example

To reproduce

  1. Go to 'Panel'
  2. Upload an .avif file somewhere
  3. See file info

Your setup

Kirby Version
4.0.3

Your system

  • OS: macOS 13.6.3
  • Browser: FF Developer
  • Version: 122.0b9
@distantnative distantnative self-assigned this Jan 14, 2024
@distantnative
Copy link
Member

Having raised PHP requirement to 8.1 we can actually do that!

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jan 14, 2024
@distantnative distantnative added this to the 4.0.4 milestone Jan 14, 2024
distantnative added a commit that referenced this issue Jan 14, 2024
@distantnative
Support dimensions for avif images
1636895 
Fixes #6141
@distantnative distantnative linked a pull request Jan 14, 2024 that will close this issue
Support dimensions for avif images #6143
Merged
5 tasks
@crisgraphics
Copy link
Author

Thank You very much Nico!

@distantnative
Copy link
Member

I have to correct myself though: only seems to work on php 8.2 without compiling special version of php

bastianallgeier pushed a commit that referenced this issue Jan 15, 2024
@distantnative @bastianallgeier
Support dimensions for avif images
3d8236c 
Fixes #6141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.0.4
Development

Successfully merging a pull request may close this issue.

Support dimensions for avif images getkirby/kirby
3 participants
@bastianallgeier @distantnative @crisgraphics