Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix KirbyText in image KirbyTag caption #1501 #1766

Merged
merged 2 commits into from
May 12, 2019
Merged

Fix KirbyText in image KirbyTag caption #1501 #1766

merged 2 commits into from
May 12, 2019

Conversation

distantnative
Copy link
Member

Describe the PR

Makes this work:

(image: myimage.jpg caption: This is an *awesome* image and this a <a href="">link</a>)

Related issues

Todos

  • Add unit tests for fixed bug/feature
  • Pass all unit tests
  • Fix code style issues with CS fixer and composer fix

@distantnative distantnative self-assigned this May 11, 2019
@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label May 11, 2019
@distantnative distantnative added this to the 3.1.4 milestone May 11, 2019
@bastianallgeier bastianallgeier merged commit dab27de into develop May 12, 2019
@bastianallgeier bastianallgeier deleted the fix/kirbytag-caption branch May 12, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @bastianallgeier