Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When discussing #1520 with @distantnative, I noticed that Kirby's
srcset
method is limited to resizing and doesn't take additional options for cropping or other image manipulations. This pull request intends to add this by switching from theresize
to thethumb
method for url generation.The
$sizes
variable now accepts a new array structure moving the image condition to the key and the image options to the value:The old condition syntax
still works for compatibility reasons but should be replaced in the docs with the more powerful proposed syntax in this pull request in my eyes.
The simple syntax of defining a plain array of widths has not been changed.
Related issues
Todos
composer fix
👆 I have no idea what is really needed from this list and how it's done.