API: Respect configured locale on single-lang site #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$kirby->setCurrentLanguage()` method not only sets the active language, but also the active PHP locale. It should be called for every API request, no matter if a language is specified or not. The method will automatically fall back to the default language and its locale – or on single-lang sites to the configured `locale` option.
lukasbestle
force-pushed
the
fix/api-configured-locale
branch
from
a2fd12d
to
e87fa23
Compare
lukasbestle
force-pushed
the
fix/api-configured-locale
branch
from
e87fa23
to
0057b45
Compare
bastianallgeier
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$kirby->setCurrentLanguage()method not only sets the active language, but also the active PHP locale. It should be called for every API request, no matter if a language is specified or not.The method will automatically fall back to the default language and its locale – or on single-lang sites to the configured
localeoption.Forum thread: https://forum.getkirby.com/t/using-sortby-with-special-language-specific-characters/15781?u=lukasbestle