Fix csp issues by introducing a new $kirby->nonce() method #1527 #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng” all external and inline sources #1527
|
@bastianallgeier don't we need to add it to our headers/CSP for it to have any effect? |
|
I thought the last decision was to not set any CSP but implement the nonce in case you want to roll your own CSP. |
|
Understood. And a bit embarrassed cause in the link issue my post is the one summarizing what to do as our collective decision exactly as you implemented it XD |
distantnative
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The Kirby class now has a new
$kirby->nonce()which returns the nonce used for all external and inline scripts + svg + stylesheets). You can use this to set your own CSP and the panel will still workRelated issues