Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New $fileCache->root() method #2434

Merged
merged 1 commit into from
Feb 10, 2020
Merged

New $fileCache->root() method #2434

merged 1 commit into from
Feb 10, 2020

Conversation

lukasbestle
Copy link
Member

Describe the PR

Makes it possible to store other types of files in the cache folder.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Fixed code style issues with CS fixer and composer fix
  • Added in-code documentation (if needed)

@lukasbestle lukasbestle added type: enhancement ✨ Suggests an enhancement; improves Kirby status: to review 👀 labels Feb 9, 2020
@lukasbestle lukasbestle added this to the 3.3.4 milestone Feb 9, 2020
@lukasbestle lukasbestle self-assigned this Feb 9, 2020
@lukasbestle lukasbestle mentioned this pull request Feb 9, 2020
Closed
This was referenced Feb 9, 2020
Closed
Closed
@bastianallgeier bastianallgeier merged commit 2da2694 into develop Feb 10, 2020
@bastianallgeier bastianallgeier deleted the feature/filecache-root branch February 10, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@lukasbestle lukasbestle

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
3.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukasbestle @bastianallgeier