Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes converting paragraph editor to blocks #3210

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

afbora
Copy link
Member

@afbora afbora commented Mar 15, 2021

Describe the PR

Adding the <p> tag when converting editor to blocks, which is the suggestion of @mrflix, is applied.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Added in-code documentation (if needed)
  • CI passes (runs automatically when the PR is created or run composer ci locally)
    Running locally requires PHPUnit, PHP-CS-Fixer, Psalm, PHPCPD and PHPMD.

@afbora afbora added type: enhancement ✨ Suggests an enhancement; improves Kirby difficulty: easy 🤩 labels Mar 15, 2021
@afbora afbora added this to the 3.5.4 milestone Mar 15, 2021
@afbora afbora requested a review from a team March 15, 2021 12:13
@afbora afbora self-assigned this Mar 15, 2021
@afbora afbora linked an issue Mar 15, 2021 that may be closed by this pull request
@bastianallgeier bastianallgeier merged commit 9cfe87e into develop Apr 27, 2021
@bastianallgeier bastianallgeier deleted the fix/3204-blocks-paragraph-converter branch April 27, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor → Blocks conversion of paragraph lacks <p>
2 participants