Whoops: Allow Exceptions to send custom HTTP code #3237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Whoops overrides any sent HTTP code with its own
HTTP 500
unless disabled. This meant that any JSON error response would haveHTTP 500
even if theException
has defined a different code.It's still the same with the HTML output, but here it's more difficult to set a custom code as we don't have dynamic access to the handled
Exception
.Ready?
Added unit tests for fixed bug/featureAutomated Whoops tests are not possiblecomposer ci
locally)Running locally requires PHPUnit, PHP-CS-Fixer, Psalm, PHPCPD and PHPMD.