-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting the page cache expiry from controllers #3246
Conversation
1b9cb13
to
09de1b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great like the getkirby/getkirby.com#1304 PR 👍
Two smaller comments. Otherwise looks good, it's a cool feature that makes caching more flexible. |
I really like this! Makes caching so much more flexible. |
@lukasbestle I was about to change the method name, but for some reason there's a local issue in my tests with timestamps. |
A `$minutes` value of 1000000000 equals 1902 years, so I don't expect anyone to have used such a high value in the past.
09de1b5
to
7cf9f5a
Compare
I've changed the method name and also added the feature to pass the number of minutes to the |
Describe the PR
Ready?
composer ci
locally)Running locally requires PHPUnit, PHP-CS-Fixer, Psalm, PHPCPD and PHPMD.