Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes offsetTop error on new dropup feature #3467

Merged
merged 1 commit into from Jun 29, 2021
Merged

Fixes offsetTop error on new dropup feature #3467

merged 1 commit into from Jun 29, 2021

Conversation

afbora
Copy link
Member

@afbora afbora commented Jun 28, 2021 •
edited

Describe the PR

  • Getting Cannot read property 'offsetTop' of null error (especially date and tags field) when dropdown doesn't contains .k-dropdown-item.
  • I've fixed with getting dropdown content height for global solution instead last menu item position.
  • Also disabled for autocomplete dropdown in tags field because tags working with multi-line and dropup doesn't working properly after first line.

Release notes

None

Breaking changes

None

Related issues/ideas

None

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • CI checks pass

When merging

@afbora afbora added type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions labels Jun 28, 2021
@afbora afbora added this to the 3.5.7 milestone Jun 28, 2021
@afbora afbora requested a review from a team June 28, 2021 22:57
@afbora afbora self-assigned this Jun 28, 2021
@bastianallgeier bastianallgeier merged commit aec6482 into release/3.5.7 Jun 29, 2021
@bastianallgeier bastianallgeier deleted the fix/dropup-issue branch June 29, 2021 08:16
This was referenced Jun 30, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Projects
None yet
Milestone
3.5.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afbora @bastianallgeier