Solve update and revert issues in the writer

[bastianallgeier]

Describe the PR

Prosemirror takes the content and applies its own HTML parsing rules. This means that whenever you add a new value to the Writer field from the backend or the value is being pasted from the clipboard, Prosemirror needs to have another look at the HTML first and make adjustments if needed.

So far, there was no update event after Prosemirror finished its own adjustments. That could cause a difference between the value that was pasted initially and whatever Prosemirror made out of it.

With this PR, the writer instantly sends an update if the initial HTML is different from the adjusted HTML. This update will make sure that the changes store is correct and reverting can happen properly.

Release notes

Fixes

• Fixed unrevertable changes in the writer and block fields
  • [3.6.0-beta.2] Stuck in an unsaved changes loop #3736
  • Odd "Revert" behaviour with content converted from Editor to Blocks #3008 (comment)

Fixed regressions from 3.6.0-beta.2

• Copy & Paste in list blocks doesn't work [3.6.0-alpha.4] Copy & Paste in list blocks doesn't work on the first try #3728

Breaking changes

None

Related issues/ideas

• [3.6.0-beta.2] Stuck in an unsaved changes loop #3736
• Odd "Revert" behaviour with content converted from Editor to Blocks #3008 (comment)
• [3.6.0-alpha.4] Copy & Paste in list blocks doesn't work on the first try #3728

Ready?

• Unit tests for fixed bug/feature
• In-code documentation (wherever needed)
• CI checks pass

When merging

• Add to website docs release checklist (if needed)
• Add changes to release notes draft in Notion

[afbora]

The savebar doesn't appear when I click it 🎉

But even if I save the page, the savebar appears every time I refresh the page.

[bastianallgeier]

@afbora really? 😭😭😭😭

[bastianallgeier]

@afbora I just tried again and cannot reproduce the behaviour you describe. Can you post the steps you are taking?

[afbora]

@bastianallgeier Here my steps

revert.mp4

[bastianallgeier]

So it only happens when you paste something or also when you create blocks manually?

[bastianallgeier]

Ok, I guess I just answered it myself. I can reproduce it when I paste stuff.

[afbora]

Paste, yes. I'm digging which block occured when paste.

[afbora]

I guess this issue about   chars somewhere when pasting.

Actually

<p>The&nbsp;<code>split()</code>&nbsp;method similarly applies when dealing with a <a href="https://getkirby.com/docs/reference/panel/fields/multiselect" rel="noopener noreferrer">multiselect</a> field.</p>

Expected

<p>The <code>split()</code> method similarly applies when dealing with a <a href="https://getkirby.com/docs/reference/panel/fields/multiselect" rel="noopener noreferrer">multiselect</a> field.</p>

[bastianallgeier]

Yes, but this should still be solved as soon as you safe and reload.

[afbora]

I've noticed, inserting \u00a0 char for space when pasting. When update \u00a0 to empty space ( ) manually (from content file), issue disappeared.

[bastianallgeier]

Ok, I think I found it this time. When you paste from the clipboard, the OS/browser is adding invisible non-breaking spaces. Those cause the difference between the final HTML and the current state. It's pretty messed up, but the solution seems simple.

[bastianallgeier]

Shit. It's still not fully solved. I hate this shit.

[bastianallgeier]

Getting there

[afbora]

Now works great except codecov 🙂

[bastianallgeier]

@afbora fixed