Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blocks field empty prop #3873

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Fix blocks field empty prop #3873

merged 1 commit into from
Oct 30, 2021

Conversation

afbora
Copy link
Member

@afbora afbora commented Oct 29, 2021 •
edited by bastianallgeier

Describe the PR

Fixed broken empty prop when adding copy/paste feature.

Release notes

Fixed regressions from 3.6.0-rc.2

Breaking changes

None

Related issues/ideas

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • CI checks pass

When merging

@afbora afbora added type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions labels Oct 29, 2021
@afbora afbora added this to the 3.6.0-rc.3 milestone Oct 29, 2021
@afbora afbora requested a review from a team October 29, 2021 18:13
@afbora afbora self-assigned this Oct 29, 2021
@afbora afbora linked an issue Oct 29, 2021 that may be closed by this pull request
[3.6.0-rc.2] Blocks field empty prop not working #3872
Closed
distantnative
distantnative approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@distantnative distantnative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - exactly like we do it in other places too 👍

@bastianallgeier bastianallgeier merged commit 59ab18f into develop Oct 30, 2021
@bastianallgeier bastianallgeier deleted the fix/3872-blocks-field-empty-prop branch October 30, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@distantnative distantnative distantnative approved these changes

Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Projects
None yet
Milestone
3.6.0-rc.3
Development

Successfully merging this pull request may close these issues.

[3.6.0-rc.2] Blocks field empty prop not working
3 participants
@afbora @bastianallgeier @distantnative