Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The empty box no longer creates a button if the action is not allowed #3918

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Nov 7, 2021

Describe the PR

The click event of the empty box in pages and files sections should not be defined if it's actually not possible to click it. This is a fix for a regression.

Release notes

Breaking changes

None

Related issues/ideas

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • CI checks pass

When merging

@bastianallgeier bastianallgeier added this to the 3.6.0-rc.5 milestone Nov 7, 2021
@bastianallgeier bastianallgeier requested a review from a team November 7, 2021 14:39
@bastianallgeier bastianallgeier merged commit 63d9aa1 into develop Nov 7, 2021
@bastianallgeier bastianallgeier deleted the fix/3915-empty-box-cursor branch November 7, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants