Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade phpmailer #4021

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

distantnative
Copy link
Member

No description provided.

@distantnative distantnative self-assigned this Dec 8, 2021
@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Dec 8, 2021
@distantnative distantnative added this to the 3.6.1.1 milestone Dec 8, 2021
@lukasbestle
Copy link
Member

Have you checked that all of our dependencies officially support PHP 8.1?

@afbora
Copy link
Member

afbora commented Dec 8, 2021

Unmaintained repos technically work and support PHP 8.1.

  • michelf/php-smartypants
  • mustangostang/spyc

Others seem to have official PHP 8.1 support.

@distantnative
Copy link
Member Author

What about whooops? According to packagist it might only support 8.0 officially: https://packagist.org/packages/filp/whoops

@afbora
Copy link
Member

afbora commented Dec 8, 2021

@afbora
Copy link
Member

afbora commented Dec 8, 2021

Also ^8.0 mean 8.x?

@distantnative
Copy link
Member Author

ah right, composer version syntax still confuses me again and again. but makes sense, I thought I had seen that whoops supports it.

@distantnative distantnative merged commit 8d9b2f5 into develop Dec 8, 2021
@distantnative distantnative deleted the release-3.6.1.1/upgrade-phpmailer branch December 8, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants