Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input rule update for italic text #4112

Merged
merged 1 commit into from Jan 25, 2022
Merged

Input rule update for italic text #4112

merged 1 commit into from Jan 25, 2022

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jan 25, 2022 •
edited

Fixes

  • Avoid the gender star issue with italic markdown shortcuts.

Related issues/ideas

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • CI checks pass

When merging

@bastianallgeier bastianallgeier requested a review from a team January 25, 2022 11:54
@bastianallgeier bastianallgeier changed the base branch from main to develop January 25, 2022 11:54
@bastianallgeier bastianallgeier added this to the 3.6.2 milestone Jan 25, 2022
afbora
afbora approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@afbora afbora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉

@bastianallgeier bastianallgeier merged commit 05a6be5 into develop Jan 25, 2022
@bastianallgeier bastianallgeier deleted the fix/3138-input-rule-update branch January 25, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbora afbora afbora approved these changes

@distantnative distantnative distantnative approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.2
Development

Successfully merging this pull request may close these issues.

Writer field: Option to disable markdown input
3 participants
@bastianallgeier @afbora @distantnative