Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list padding #4254

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix list padding #4254

merged 1 commit into from
Apr 6, 2022

Conversation

bastianallgeier
Copy link
Member

Fixes

Screenshot 2022-04-06 at 12 57 06

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@bastianallgeier bastianallgeier added this to the 3.6.5 milestone Apr 6, 2022
@bastianallgeier bastianallgeier requested a review from a team April 6, 2022 10:59
@distantnative
Copy link
Member

Would we have the same problem again once someone gets to 100.?

@bastianallgeier
Copy link
Member Author

@distantnative yes, but I think that's such a major edge case that I find it acceptable.

@distantnative distantnative merged commit 59d8715 into develop Apr 6, 2022
@distantnative distantnative deleted the fix/4245-list-padding branch April 6, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distantnative distantnative distantnative approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastianallgeier @distantnative