Uri: Allow disabling the params parsing
#4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `params` prop can now be set to `false` to treat colons/semicolons in the path as literals and not as param separators. This is useful for parsing external non-Kirby URIs. Fixes #2948.
lukasbestle
added
the
type: enhancement ✨
bastianallgeier
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Enhancements
Uriclass, theparamsprop can now be set tofalseto treat colons/semicolons in the path as literals and not as param separators. This is useful for parsing external non-Kirby URIs. Url functions mistake some paths with colon (:) as Param #2948Breaking changes
None
Ready?
For review team