Fix multi selecting blocks without click #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbora
changed the title
bastianallgeier
force-pushed
the
fix/4319-multi-select
branch
from
f545233
to
5db1d6c
Compare
|
I rebased and moved the event registration to the created method to only register it once. Otherwise it would have been registered multiple times on every select call. @distantnative @afbora could you have another look at it? |
bastianallgeier
previously approved these changes
Jul 4, 2022
|
Thank you @bastianallgeier for improvement 💛 Still works great! I leave the technical review to @distantnative |
distantnative
previously approved these changes
Jul 4, 2022
distantnative
dismissed stale reviews from bastianallgeier and themself
via
4b6a06b
distantnative
force-pushed
the
fix/4319-multi-select
branch
from
5db1d6c
to
4b6a06b
Compare
distantnative
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
The issue fixed with listening
window.addEventListener('blur')event and reset the multi select mode.Fixes
Breaking changes
none
Ready?
[ ] Unit tests for fixed bug/featureFor review team
[ ] Add to website docs release checklist (if needed)