Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support anonymous plugins (without .php file) #4445

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jun 29, 2022

This PR …

Enhancements

  • Plugins that only provide Panel styles and/or scripts don't need to add an index.php anymore, index.js and index.css will still be included in the Panel by registering an anonymous plugin for them automatically
    Fixes Initializing plugins which don't require PHP #4419

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative self-assigned this Jun 29, 2022
@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jun 29, 2022
src/Cms/AppPlugins.php Outdated Show resolved Hide resolved
@distantnative distantnative force-pushed the feature/4419-anonymous-plugins branch from d28aa8b to 038d9b0 Compare June 29, 2022 18:28
@distantnative distantnative marked this pull request as ready for review June 29, 2022 18:38
@distantnative distantnative requested a review from a team June 29, 2022 18:38
@distantnative distantnative added this to the 3.7.1 milestone Jun 29, 2022
@distantnative distantnative force-pushed the feature/4419-anonymous-plugins branch from 2dfd6b1 to 89b3988 Compare June 29, 2022 19:00
@distantnative distantnative merged commit 4ff207d into develop Jun 30, 2022
@distantnative distantnative deleted the feature/4419-anonymous-plugins branch June 30, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants