Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #4478

Merged
merged 3 commits into from Jul 14, 2022
Merged

Remove deprecated code #4478

merged 3 commits into from Jul 14, 2022

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jul 5, 2022

This PR …

Removed deprecated code

  • Removed Server class alias
  • Removed API model method page.next and page.prev
  • markdown component: Removed $inline parameter. Use $options['inline'] instead.
  • $kirby->kirbytext(): Removed $inlineparameter. Use$options['markdown']['inline']` instead.
  • $kirby->markdown(): Passing a boolean as second parameter isn't supported anymore. Use $options['inline'] instead.
  • Removed Cms\File::dragText(). Use $file->panel()->dragText() instead.
  • Removed Cms\File::panelOptions(). Use $file->panel()->options() instead.
  • Removed Cms\File::panelPath(). Use $file->panel()->path() instead.
  • Removed Cms\File::panelPickerData(). Use $file->panel()->pickerData() instead.
  • Removed Cms\File::panelUrl(). Use $file->panel()->url() instead.
  • Removed Cms\Files::findById(). Use $files->find() instead.
  • Removed Cms\ModelWithContent::panelIcon(). Use $model->panel()->image() instead.
  • Removed Cms\ModelWithContent::panelImage(). Use $model->panel()->image() instead.
  • Removed Cms\ModelWithContent::panelOptions(). Use $model->panel()->options() instead.
  • Removed Cms\Page::dragText(). Use $page->panel()->dragText() instead.
  • Removed Cms\Page::panelId(). Use $page->panel()->id() instead.
  • Removed Cms\Page::panelPath(). Use $page->panel()->path() instead.
  • Removed Cms\Page::panelPickerData(). Use $page->panel()->pickerData() instead.
  • Removed Cms\Page::panelUrl(). Use $page->panel()->url() instead.
  • Removed Cms\Pages::findById(). Use $pages->find() instead.
  • Removed Cms\Pages::findByUri(). Use $pages->find() instead.
  • Removed Cms\Site::panelPath(). Use $site->panel()->path() instead.
  • Removed Cms\Site:panelUrl(). Use $site->panel()->url() instead.
  • Removed Cms\User::panelPath(). Use $user->panel()->path() instead.
  • Removed Cms\User::panelPickerData(). Use $user->panel()->pickerData() instead.
  • Removed Cms\User:panelUrl(). Use $user->panel()->url() instead.
  • Removed Panel\Document::customCss(). Use Panel\Document::customAsset('panel.css') instead.
  • Removed Panel\Document::customJs(). Use Panel\Document::customAsset('panel.js') instead.
  • Removed Cms\Server. Use Cms\Environment instead.
  • Removed Toolkit\Str::isUrl(). Use Toolkit\V::url() instead.

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative self-assigned this Jul 5, 2022
@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Jul 5, 2022
@distantnative distantnative added this to the 3.8.0 milestone Jul 5, 2022
@distantnative distantnative force-pushed the release-3.8/deprecations branch 2 times, most recently from 739dc15 to 7f7ca97 Compare July 11, 2022 07:34
@distantnative distantnative marked this pull request as ready for review July 11, 2022 07:36
@distantnative distantnative requested a review from a team July 11, 2022 07:37
@bastianallgeier bastianallgeier merged commit 4e84eb0 into features Jul 14, 2022
@bastianallgeier bastianallgeier deleted the release-3.8/deprecations branch July 14, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants