Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment fixes and unit tests #4490

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Environment fixes and unit tests #4490

merged 4 commits into from
Jul 12, 2022

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Jul 11, 2022

This PR …

Enhancements

  • Kirby now takes the Forwarded header into account when checking whether the Panel is installable on a local installation

Internal changes (not for release notes)

  • Fix test coverage reporting for Environment
  • Add missing tests for Forwarded header feature and fixes
  • Add missing test for empty port values
  • Cleanup of removed root option
  • Fix bugs in Forwarded header parser

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@lukasbestle lukasbestle added type: bug 🐛 Is a bug; fixes a bug type: refactoring ♻️ Is about bad code; cleans up code type: tests 🧪 Is about missing tests; increases test coverage or improves tests labels Jul 11, 2022
@lukasbestle lukasbestle added this to the 3.7.1 milestone Jul 11, 2022
@lukasbestle lukasbestle changed the title Feature/env tests Environment fixes and unit tests Jul 12, 2022
@distantnative distantnative merged commit 435a910 into develop Jul 12, 2022
@distantnative distantnative deleted the feature/env-tests branch July 12, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug type: refactoring ♻️ Is about bad code; cleans up code type: tests 🧪 Is about missing tests; increases test coverage or improves tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants