Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UsersView: only show filter when more than 1 role #4673

Merged
merged 1 commit into from Sep 20, 2022
Merged

UsersView: only show filter when more than 1 role #4673

merged 1 commit into from Sep 20, 2022

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Sep 20, 2022 •
edited by bastianallgeier

This PR …

Fixes

  • Users view: role filter is not shown anymore if there is only one role available

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Sep 20, 2022
@distantnative distantnative added this to the 3.8.0 or 3.8.x milestone Sep 20, 2022
@distantnative distantnative self-assigned this Sep 20, 2022
@distantnative distantnative requested a review from a team September 20, 2022 09:59
@bastianallgeier bastianallgeier merged commit 5a34c32 into develop Sep 20, 2022
@bastianallgeier bastianallgeier deleted the fix/users-role-filter branch September 20, 2022 14:56
@bastianallgeier bastianallgeier modified the milestones: 3.8.0 or 3.8.x, 3.8.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @bastianallgeier