Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue: restructure app setup #4820

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Vue: restructure app setup #4820

merged 5 commits into from
Nov 16, 2022

Conversation

distantnative
Copy link
Member

In anticipation of Vue 3:

  • remove importing Vue globally as much as possible
  • register e.g. component instead via Vue plugin that receives app instance in Vue 3 (in Vue 2.7 still global Vue)

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label Oct 27, 2022
@distantnative distantnative requested a review from a team October 27, 2022 11:40
@distantnative distantnative self-assigned this Oct 27, 2022
@distantnative distantnative added this to the 3.8.2 milestone Oct 31, 2022
@bastianallgeier
Copy link
Member

@distantnative could you have another look at the index.js and see if I fixed the conflict correctly?

@bastianallgeier
Copy link
Member

Shit. Looks like i made a mistake, but I'm not sure what's the correct way to do it.

@bastianallgeier bastianallgeier modified the milestones: 3.8.2, 3.8.3 Nov 8, 2022
@distantnative
Copy link
Member Author

@bastianallgeier fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants