Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New templatesIgnore for pages section #5322

Merged
merged 1 commit into from Jun 23, 2023
Merged

New templatesIgnore for pages section #5322

merged 1 commit into from Jun 23, 2023

Conversation

afbora
Copy link
Member

@afbora afbora commented Jun 22, 2023 •
edited by bastianallgeier

This PR …

Background is here #5232

🎉 Features

Breaking changes

None

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@afbora afbora added the type: feature 🎉 Adds a feature (requests → feedback.getkirby.com) label Jun 22, 2023
@afbora afbora added this to the 4.0.0 milestone Jun 22, 2023
@afbora afbora requested a review from a team June 22, 2023 17:57
@afbora afbora self-assigned this Jun 22, 2023
@afbora afbora force-pushed the v4/feature/130-templates-ignore-pages-section branch from e21ed4e to 426f6b3 Compare June 22, 2023 18:04
@afbora afbora force-pushed the v4/feature/130-templates-ignore-pages-section branch from 3f5021b to 074bf96 Compare June 22, 2023 18:09
bastianallgeier
bastianallgeier approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@bastianallgeier bastianallgeier merged commit c9ff6ce into v4/develop Jun 23, 2023
14 checks passed
@bastianallgeier bastianallgeier deleted the v4/feature/130-templates-ignore-pages-section branch June 23, 2023 07:34
@afbora afbora modified the milestones: 4.0.0, 4.0.0-alpha.4 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
type: feature 🎉 Adds a feature (requests → feedback.getkirby.com)
Projects
None yet
Milestone
4.0.0-alpha.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afbora @bastianallgeier