Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link field preview #5834

Merged
merged 20 commits into from
Jan 22, 2024
Merged

Link field preview #5834

merged 20 commits into from
Jan 22, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Oct 20, 2023 •
edited by bastianallgeier

This PR …

  • Fix styling in link field now its based on k-bubble
  • No remove button due to k-bubble vs. k-tag
  • v4.x: switch to k-tag based
  • v4.x: integrate fetching into k-pages-field-preview and k-files-field-preview

Enhancements

  • New text and html props for the k-tag component
  • New cancel-small icon version
  • Field preview for link field
  • New $helper.link

@distantnative distantnative self-assigned this Oct 20, 2023
@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Oct 20, 2023
@distantnative distantnative added this to the 4.0.0 milestone Oct 20, 2023
@distantnative distantnative modified the milestones: 4.0, 4.1 Oct 21, 2023
@distantnative distantnative linked an issue Oct 29, 2023 that may be closed by this pull request
[v4] Link field doesn't have a structure preview #5262
Closed
@distantnative distantnative changed the base branch from v4/develop to develop November 28, 2023 09:20
@distantnative distantnative changed the base branch from develop-patch to develop-minor November 29, 2023 14:22
@bastianallgeier bastianallgeier marked this pull request as ready for review January 18, 2024 14:06
distantnative and others added 17 commits January 18, 2024 20:31
distantnative
distantnative commented Jan 18, 2024
View reviewed changes
Copy link
Member Author

@distantnative distantnative left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastianallgeier Looks great overall!

Just the default tags image looks a bit odd to me:
Screenshot 2024-01-18 at 20 40 39

Shouldn't it look more like this?
Screenshot 2024-01-18 at 20 39 55

@bastianallgeier
Copy link
Member

@distantnative I've adjusted the styles. The images are now always full height.

@bastianallgeier bastianallgeier merged commit 4b634ba into develop-minor Jan 22, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the v4/enhacement/link-preview branch January 22, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

[v4] Link field doesn't have a structure preview
2 participants
@distantnative @bastianallgeier