Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Vite 5 #5984

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Upgrade to Vite 5 #5984

merged 4 commits into from
Dec 15, 2023

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 21, 2023 •
edited

  • Upgrades to vite 5
  • Manually includes tailored prismjs
  • Remove lightning's again (much larger bundle size with it)

@distantnative distantnative added needs: information ❓ Requires more information to proceed type: enhancement ✨ Suggests an enhancement; improves Kirby labels Nov 21, 2023
@distantnative distantnative added this to the 4.0.0-rc.3 milestone Nov 21, 2023
@distantnative distantnative self-assigned this Nov 21, 2023
@distantnative
Copy link
Member Author

Ok the bundle sizes are very different, so I think it somehow slimmed prismjs down.
Unfortunately the plugin isn't maintained anymore and clashes with Vite 5 moving to ESM for the config file.

@bastianallgeier
Copy link
Member

Is it worth to upgrade at all before the launch?

@distantnative
Copy link
Member Author

No. Let's do it for 4.1 - issue/questions remain though

@distantnative distantnative modified the milestones: 4.0.0-rc.3, 4.1.0 Nov 22, 2023
@bastianallgeier
Copy link
Member

When I installed the plugin, it was part of the installation process to put it in the vite config. I honestly never thought about what it does exactly.

@distantnative distantnative changed the base branch from v4/develop to develop November 28, 2023 09:20
@distantnative distantnative marked this pull request as draft November 28, 2023 10:03
@distantnative distantnative changed the base branch from develop-patch to develop-minor November 29, 2023 14:21
@distantnative distantnative removed the needs: information ❓ Requires more information to proceed label Dec 9, 2023
@distantnative distantnative requested a review from a team December 9, 2023 11:26
@distantnative distantnative marked this pull request as ready for review December 9, 2023 11:29
@bastianallgeier bastianallgeier merged commit eac0efd into develop-minor Dec 15, 2023
4 checks passed
@bastianallgeier bastianallgeier deleted the v4/enhancement/vite-5 branch December 15, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @bastianallgeier