Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EULA: Format info blocks for GitHub #6060

Merged
merged 1 commit into from
Dec 11, 2023
Merged

EULA: Format info blocks for GitHub #6060

merged 1 commit into from
Dec 11, 2023

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Dec 10, 2023 •
edited by bastianallgeier
Loading

This PR …

Refactoring

  • The license file included in the Kirby repo is now formatted correctly on GitHub

For review team

@lukasbestle lukasbestle added the type: refactoring ♻️ Is about bad code; cleans up code label Dec 10, 2023
@lukasbestle lukasbestle added this to the 4.0.2 milestone Dec 10, 2023
@lukasbestle lukasbestle requested a review from a team December 10, 2023 21:24
@lukasbestle
Copy link
Member Author

This is how it will look like: https://github.com/getkirby/kirby/blob/feature/license-formatting/LICENSE.md

bastianallgeier
bastianallgeier approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note blocks are really nice

@bastianallgeier bastianallgeier merged commit 3f10e03 into develop-patch Dec 11, 2023
12 checks passed
@bastianallgeier bastianallgeier deleted the feature/license-formatting branch December 11, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees
No one assigned
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukasbestle @bastianallgeier