Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages section table: add field types for columns #6147

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

distantnative
Copy link
Member

This PR …

Enhancement

  • Page and files section with table layout will now try to infer the column type from the blueprint of the first model when no type has been provided explicitly

Breaking changes

I think none as columnsWithTypes is a new function that our pages/files section uses - but any plugin extending those sections can still use columns like before.

For review team

  • Add changes to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Jan 15, 2024
@distantnative distantnative added this to the 4.1.0 milestone Jan 15, 2024
@distantnative distantnative requested review from a team January 15, 2024 09:02
@distantnative distantnative self-assigned this Jan 15, 2024
@distantnative distantnative linked an issue Jan 15, 2024 that may be closed by this pull request
@bastianallgeier
Copy link
Member

What happens when one of the pages has a different blueprint with different field types?

@distantnative
Copy link
Member Author

@bastianallgeier Would clash. But no idea how to resolve that.

@bastianallgeier
Copy link
Member

I wonder if the table layout should actually be limited to pages sections that only define a single template. That would make a lot of sense, not only if we implement this.

@bastianallgeier bastianallgeier merged commit 5d3530b into develop-minor Jan 15, 2024
10 of 12 checks passed
@bastianallgeier bastianallgeier deleted the fix/6120-items-table-infer-fields branch January 15, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 color field previews
2 participants