Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color field: fix options from query #6152

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 15, 2024

This PR …

Fixed (not for release notes as it fixes unreleased changes)

Refactored

  • Color field: options should be written as $value => $name, e.g.
options:
  "#F8B195": "Sunny rays"
  "#F67280": "First-love blush"
  "#C06C84": "Cherry blossom"
  "#6C5B7B": "Morning gloom"
  "#355C7D": "Midnight rain"

Deprecated

  • Color field: writing options as $name => value has been deprecated

Ready?

  • Unit tests for fixed bug/feature
  • In-code documentation (wherever needed)
  • Tests and checks all pass

For review team

@distantnative distantnative added type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions critical: roadblock 🚧 Needs to be solved first needs: two-person review 🧑‍🤝‍🧑 PR must only be merged with two approvals labels Jan 15, 2024
@distantnative distantnative added this to the 4.1.0 milestone Jan 15, 2024
@distantnative distantnative self-assigned this Jan 15, 2024
@distantnative distantnative removed the type: regression 🚨 Is a regression between versions label Jan 15, 2024
@distantnative distantnative marked this pull request as ready for review January 15, 2024 11:32
@distantnative distantnative linked an issue Jan 15, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change the order of the props here to make sure that you can still have custom text and value definitions for your queries. I've also added more examples to the sandbox

@bastianallgeier bastianallgeier merged commit de60c95 into develop-minor Jan 15, 2024
6 of 9 checks passed
@bastianallgeier bastianallgeier deleted the fix/color-field-options-query branch January 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical: roadblock 🚧 Needs to be solved first needs: two-person review 🧑‍🤝‍🧑 PR must only be merged with two approvals type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.1] Investigate color field dynamic options
2 participants