Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent disabled blocks #6160

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Consistent disabled blocks #6160

merged 6 commits into from
Jan 17, 2024

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jan 16, 2024 •
edited

This PR …

Enhancement

  • Extensive block examples in the lab

Fixes

Breaking changes

None

For review team

@bastianallgeier bastianallgeier added this to the 4.1.0 milestone Jan 16, 2024
@bastianallgeier bastianallgeier changed the base branch from main to develop-minor January 16, 2024 13:05
@bastianallgeier bastianallgeier requested a review from a team January 16, 2024 13:06
@distantnative
Copy link
Member

Screenshot 2024-01-16 at 14 29 43

The empty gallery block looks a bit odd disabled

@distantnative
Copy link
Member

We could do

.k-block-type-gallery[data-disabled="true"] .k-block-type-gallery-placeholder {
	background: var(--color-gray-300);
}
Screenshot 2024-01-16 at 14 39 53

@bastianallgeier bastianallgeier merged commit 7b6fa51 into develop-minor Jan 17, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/5100-disabled-blocks branch January 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distantnative distantnative Awaiting requested review from distantnative

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bastianallgeier @distantnative