Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkField: fix dropdown for only option #6192

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

distantnative
Copy link
Member

This PR …

Fixes

For review team

  • Add changes to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Jan 23, 2024
@distantnative distantnative added this to the 4.1.0 milestone Jan 23, 2024
@distantnative distantnative self-assigned this Jan 23, 2024
@afbora
Copy link
Member

afbora commented Jan 24, 2024

TypeError: Cannot read properties of undefined (reading 'type')

Getting console error when single option that not have dropdown like url option.

link:
  type: link
  options:
    - url

Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I've added two more examples to the sandbox.

@bastianallgeier bastianallgeier merged commit ba999d2 into develop-minor Jan 24, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6186-link-field-only-opyion branch January 24, 2024 09:46
@afbora
Copy link
Member

afbora commented Jan 24, 2024

@bastianallgeier Did you see my comment?

@bastianallgeier
Copy link
Member

That's so weird. Do you see the times? Your comment is 4 minutes after mine, but still it is sorted before my approval. My guess is that you posted it earlier but it only went through after my approval. I didn't see it when I approved it. I will check again.

@afbora
Copy link
Member

afbora commented Jan 24, 2024

Really weird.

screen-capture-1814-LinkField_ fix dropdown for only option by distantnative · Pull Request #6_-github com

@bastianallgeier
Copy link
Member

@afbora I've added a fix #6197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link field with single option breaks pages dropdown on empty state
3 participants