Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorField: proper HTML/XSS handling #6195

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Jan 23, 2024

This PR …

Fixes

For review team

  • Add changes to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Jan 23, 2024
@distantnative distantnative added this to the 4.1.0 milestone Jan 23, 2024
@distantnative distantnative self-assigned this Jan 23, 2024
@distantnative distantnative linked an issue Jan 23, 2024 that may be closed by this pull request
2 tasks
@bastianallgeier
Copy link
Member

I reviewed it and all the expectations from @lukasbestle' issue are met in my opinion. But I would leave the final approval to Lukas.

Copy link
Member

@lukasbestle lukasbestle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it again with the XSS sandbox and works great now 👍

@distantnative distantnative merged commit b77bc86 into develop-minor Jan 24, 2024
16 checks passed
@distantnative distantnative deleted the fix/6183-color-field-xss branch January 24, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining inconsistencies of the color field
3 participants