-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to change number of threads for imagemagick convert #6210
Add option to change number of threads for imagemagick convert #6210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that the option in imagemagick is called thread. But I feel like the option should still be called threads. @distantnative @lukasbestle could this be something that would actually also help for @Iskris' issue?
Yeah, I thought that too. I changed the name of the option into 'threads' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with it. But it would be good to get a second opinion (@distantnative @afbora @lukasbestle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes a lot of sense to me. I think the original limit was added for shared hosting setups, but if the hardware is available, using multithreading can indeed improve the performance a lot.
Thanks for your help @caplod We will make sure to mention you in the release notes. |
This PR …
If you are converting a lot of big images with imagemagick it can get really slow.
This PR adds an option to configure the threads imagemagick can use. (default is 1)
So you can benefit from capable hardware.
Ready?
For review team