Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable license dialog in demo mode #6271

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Feb 17, 2024

Otherwise the stats widget would open an empty license dialog in the online demo

This PR …

Fixes

  • Fix demo license in the online demo to avoid an empty license dialog

Docs

None

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

Otherwise the stats widget would open an empty license dialog in the online demo
@lukasbestle lukasbestle added the type: bug 🐛 Is a bug; fixes a bug label Feb 17, 2024
@lukasbestle lukasbestle added this to the 4.1.1 milestone Feb 17, 2024
@lukasbestle lukasbestle requested a review from a team February 17, 2024 20:06
@lukasbestle lukasbestle self-assigned this Feb 17, 2024
@bastianallgeier bastianallgeier merged commit 8ec414f into develop-patch Feb 19, 2024
12 checks passed
@bastianallgeier bastianallgeier deleted the fix/licensestatus-demo branch February 19, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants