Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WriterField counter #6323

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix WriterField counter #6323

merged 2 commits into from
Mar 6, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Mar 3, 2024 •
edited by bastianallgeier

This PR …

Fixes

  • Writer field counter correctly strips HTML again

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Mar 3, 2024
@distantnative distantnative added this to the 4.2.0 milestone Mar 3, 2024
@distantnative distantnative requested a review from a team March 3, 2024 10:28
@distantnative distantnative self-assigned this Mar 3, 2024
bastianallgeier
bastianallgeier reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems to be off. When I open the writer field lab example, the counter is at 4 at first when the field is still empty.

@distantnative distantnative added the needs: changes 🔁 Implement any requested changes to proceed label Mar 4, 2024
@distantnative
Copy link
Member Author

Ok sometimes JavaScript is just.... why is String(null) not "" but "null"?

@distantnative distantnative removed the needs: changes 🔁 Implement any requested changes to proceed label Mar 5, 2024
@bastianallgeier bastianallgeier merged commit ae890c0 into develop-minor Mar 6, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/writer-counter branch March 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @bastianallgeier