-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to prefill the login form #6364
Conversation
I'd suggest to just calling them email and password. And let's avoid v-bind=$propd - that'll cause issues down the road with Vue 3. already looking into how to reduce this in our existing code (so totally get why you added it as we currently use it a lot). |
4f71d1d
to
34b80cb
Compare
Got rid of Naming the props just |
34b80cb
to
c91fe85
Compare
The data object is only internally and is Alternatively, the prop would be |
c91fe85
to
e4fec39
Compare
e4fec39
to
4cf2c02
Compare
Fine for me. Went with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukasbestle looks good to me, added some inline docs for the props when we're already touching this. Also switched to inherit props to make them more consistent - we're trying to do it like that in more places recently.
Looks good, thanks for the changes. |
Main use case for me is to make it easier to log in to the Demokit. We could also use it in the Sandbox.
This PR …
Enhancements
value
prop of thek-login-view
componentBreaking changes
None
Docs
Probably too obscure to document
Ready?
For review team