Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel notifications: support for theme #6423

Merged
merged 3 commits into from
May 2, 2024
Merged

Panel notifications: support for theme #6423

merged 3 commits into from
May 2, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Apr 30, 2024 •
edited by bastianallgeier
Loading

This PR …

Enhancements

  • Panel notifications support theme prop
  • New window.panel.notification.info(message)

Docs

window.panel.notification.open({
  message: "Fun fact!",
  icon: "info",
  theme: "info"
});

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Apr 30, 2024
@distantnative distantnative added this to the 4.3.0 milestone Apr 30, 2024
@distantnative distantnative self-assigned this Apr 30, 2024
@distantnative distantnative requested a review from a team April 30, 2024 15:58
bastianallgeier
bastianallgeier approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bastianallgeier bastianallgeier merged commit 984bae0 into develop-minor May 2, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the enhancement/notifications branch May 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@distantnative distantnative

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@distantnative @bastianallgeier