Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all login components into same location #6463

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented May 30, 2024

This PR …

Moving the closely related Vue components to the same folder makes it easier to keep an overview and work on them going forward.

Refactor

  • Moved all login-related Vue components into same location
  • Aligned some of the component names

Deprecated

  • <k-login> is deprecated. Use <k-login-form> instead.
  • <k-login-code> is deprecated. Use <k-login-code-form> instead.

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: refactoring ♻️ Is about bad code; cleans up code label May 30, 2024
@distantnative distantnative added this to the 4.3.0 milestone May 30, 2024
@distantnative distantnative requested a review from a team May 30, 2024 11:45
@distantnative distantnative self-assigned this May 30, 2024
@bastianallgeier bastianallgeier merged commit 972ad11 into develop-minor Jun 1, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the refactor/login-components branch June 1, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants