Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(invoice-pdf): handle invoice pdf template issues #1677

Merged
merged 1 commit into from
Feb 9, 2024
Merged

fix(invoice-pdf): handle invoice pdf template issues #1677

merged 1 commit into from
Feb 9, 2024

Conversation

lovrocolic
Copy link
Collaborator

Context

There are few smaller issues in PDF invoice template

Description

This PR fixes:

  • customer email list -> This list is actually string with elements separated by comma. HTML by default break string on multiple lines (when needed) upon empty space detection, so we need to ensure that email list string is correctly formatted.
  • removes unnecessary word in multiple subscriptions breakdown page
  • displays adjusted subscription fee display name

@lovrocolic lovrocolic merged commit 64f0217 into main Feb 9, 2024
6 checks passed
@lovrocolic lovrocolic deleted the new-pdf-templates-fix branch February 9, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

@rsempe rsempe Awaiting requested review from rsempe

@ivannovosad ivannovosad Awaiting requested review from ivannovosad

@jdenquin jdenquin Awaiting requested review from jdenquin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovrocolic @vincent-pochet