misc: Add github action to test DB migrations #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-migration-ci
branch
21 times, most recently
from
4573bd7
to
acd4e3e
Compare
vincent-pochet
force-pushed
the
misc-migration-ci
branch
from
acd4e3e
to
9bec08b
Compare
vincent-pochet
changed the title
rsempe
approved these changes
Mar 8, 2024
julienbourdeau
added a commit
that referenced
this pull request
Apr 23, 2024
…1888) ## Description Recently, a [new Action was set up](#1761) to test DB migrations. I agree 100% that the migrations should be tested as part of the CI. I propose to run the migration when setup the Actions to run rspec instead of loading the schema. A small benefit is that we don't need to setup a dedicated env "just" to run the migrations. A big benefit is that you can only commit `db/schema.rb` when your PR is ready and still run the CI in the meantime. `schema.rb` will often cause conflicts in PR that stays open for while. We aim for short-lived PR of course, but sometimes some stay open longer.
drejc
pushed a commit
to fliqa-io/lago-api
that referenced
this pull request
May 15, 2024
…etlago#1888) ## Description Recently, a [new Action was set up](getlago#1761) to test DB migrations. I agree 100% that the migrations should be tested as part of the CI. I propose to run the migration when setup the Actions to run rspec instead of loading the schema. A small benefit is that we don't need to setup a dedicated env "just" to run the migrations. A big benefit is that you can only commit `db/schema.rb` when your PR is ready and still run the CI in the meantime. `schema.rb` will often cause conflicts in PR that stays open for while. We aim for short-lived PR of course, but sometimes some stay open longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Few issues were reported in the past with database migrations on a fresh lago install.
Since the migration are not performed from the start when deploying on the cloud instance or on the local instances, some edge case could prevent some migration to perform correctly.
Description
This PR adds a github CI action to perform the migration from scratch making sure they all perform correctly