feat(filter): Accept multiple values on a charge_filter_value #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
feat-charge-filters-multi-values
branch
2 times, most recently
from
8ec9bf0
to
a4844f3
Compare
ivannovosad
approved these changes
Mar 19, 2024
vincent-pochet
force-pushed
the
feat-charge-filters-multi-values
branch
from
a4844f3
to
0c97b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Lago is not currently supporting more than 2 levels of event grouping (parent → children)
The goal of this feature is to allow more flexibility of event grouping by allowing an unlimited level of grouping and making it easier to define default charge properties for events based on their properties.
Description
This PR turns
change_filter_values#valueintochange_filter_values#valuesto accept multiple values for a single filter.